From a2084e296af8f90fb2a0c1c3b0277215d1a0188d Mon Sep 17 00:00:00 2001 From: BodgeMaster <> Date: Thu, 14 Jul 2022 03:58:13 +0200 Subject: [PATCH] lib/error: Remove ErrorOr(bool) constructor This allows ErrorOr to be used for bool, as there would be conflicting constructors otherwise. Also, we have ErrorCodes::UNKNOWN now so, instead of `ErrorOr(true)`, `ErrorOr(true, ErrorCodes::UNKNOWN)` can be used. --- src/lib/error.h++ | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/lib/error.h++ b/src/lib/error.h++ index d0cbf97..e10d808 100644 --- a/src/lib/error.h++ +++ b/src/lib/error.h++ @@ -25,7 +25,6 @@ struct ErrorOr { ErrorOr(); ErrorOr(T); - ErrorOr(bool); ErrorOr(bool, uint8_t); ErrorOr(bool, uint8_t, T); }; @@ -43,12 +42,6 @@ ErrorOr::ErrorOr(T value) { this->value = value; } -template -ErrorOr::ErrorOr(bool isError) { - this->isError = isError; - this->errorCode = 0; -} - template ErrorOr::ErrorOr(bool isError, uint8_t errorCode) { this->isError = isError;