diff --git a/src/lib/java_string.cpp b/src/lib/java_string.cpp index 5b4a2f0..a96fe9d 100644 --- a/src/lib/java_string.cpp +++ b/src/lib/java_string.cpp @@ -20,7 +20,9 @@ #include "java_string.h++" namespace JavaCompat { - tiny_utf8::string importJavaFormatToString(uint8_t data[]) { + //FIXME: contrary to what I said, we need to explicitly pass the data + // size because files could have been tampered with or corrupted + tiny_utf8::string importJavaString(uint8_t data[]) { std::vector output; tiny_utf8::string outputString; uint16_t size = static_cast(data[0])<<8 | static_cast(data[1]); @@ -37,7 +39,7 @@ namespace JavaCompat { return tiny_utf8::string(output.begin(), output.end()); } /* - ErrorOr exportStringToJavaFormat(tiny_utf8::string data) { + ErrorOr exportJavaString(tiny_utf8::string data) { return ErrorOr(nullptr); } */ diff --git a/src/lib/java_string.h++ b/src/lib/java_string.h++ index b57f56b..24be799 100644 --- a/src/lib/java_string.h++ +++ b/src/lib/java_string.h++ @@ -17,6 +17,8 @@ #include "error.h++" namespace JavaCompat { - tiny_utf8::string importJavaFormatToString(uint8_t data[]); - ErrorOr exportStringToJavaFormat(tiny_utf8::string data); + //FIXME: contrary to what I said, we need to explicitly pass the data + // size because files could have been tampered with or corrupted + tiny_utf8::string importJavaString(uint8_t data[]); + ErrorOr exportJavaString(tiny_utf8::string data); }