BodgeMaster
/
FOSS-VG
1
0
Fork 0
Code Issues 21 Pull Requests Projects Releases Wiki Activity

lib/nbt: return correct error type from read functions #17

New Issue
Closed
opened 2022-06-29 10:38:03 +02:00 by BodgeMaster · 1 comment
BodgeMaster commented 2022-06-29 10:38:03 +02:00
Owner

I added ErrorCodes::OVERRUN_ERROR. Might be useful to know what kind of error occurred.

I added `ErrorCodes::OVERRUN_ERROR`. Might be useful to know what kind of error occurred.
BodgeMaster added this to the NBT milestone 2022-06-29 10:38:03 +02:00
BodgeMaster added the
Enhancement
 label 2022-06-29 11:08:23 +02:00
BodgeMaster changed title from Make the NBT::helper::readIntN functions use the correct error code for what happened. to NBT: Make the NBT::helper::readIntN functions use the correct error code for what happened. 2022-07-12 05:25:26 +02:00
BodgeMaster changed title from NBT: Make the NBT::helper::readIntN functions use the correct error code for what happened. to lib/nbt: Make the NBT::helper::readIntN functions use the correct error code for what happened. 2022-07-20 10:12:20 +02:00
BodgeMaster commented 2022-08-04 08:24:52 +02:00
Poster
Owner

Many of them only return OUT_OF_RANGE where they should return either OUT_OF_RANGE or OVERRUN depending on what happened.

  • OUT_OF_RANGE when currentPosition is out of bounds
  • OVERRUN when reading would would go out of bounds
Many of them only return `OUT_OF_RANGE` where they should return either `OUT_OF_RANGE` or `OVERRUN` depending on what happened. - `OUT_OF_RANGE` when `currentPosition` is out of bounds - `OVERRUN` when reading would would go out of bounds
BodgeMaster changed title from lib/nbt: Make the NBT::helper::readIntN functions use the correct error code for what happened. to lib/nbt: return correct error type from read functions 2022-08-04 08:25:09 +02:00
BodgeMaster self-assigned this 2022-08-25 17:04:20 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
jocadbz
master
cygwin
windows
broken
Soda
BodgeMaster-unfinished
Labels
Clear labels   
Bug
   
Build Problems

When building fails even though all prerequisites are met   
Discussion

Outstanding decisions   
Distribution

Necessary preparations for distribution   
Enhancement

Feature improvements   
Far Future

Ideas for when FOSS-VG is up and running reliably   
Fix Later

Low priority issue   
TODO

Needed for an immediate goal or otherwise necessary   
WONTFIX
   
Workflow

Issues with our current workflow or build system
No Label
Bug
Build Problems
Discussion
Distribution
Enhancement
Far Future
Fix Later
TODO
WONTFIX
Workflow
Milestone
Clear milestone
No items
No Milestone
NBT
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
BodgeMaster
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BodgeMaster/FOSS-VG#17
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?